Can declarative services be used in a thread?

I have the following code as an OSGi module.

When it runs, I get the message that the logger has been set:

UdpListener > setStoreLog: '[email protected]'

But immediatly after that, the loop in the run() function says that storeLog is empty

ERROR > UdpListener > run > storeLog is not available.

Any ideas what could be wrong?

Could it be the fact that this is running in a thread?

package com.mine.logger.internal.udp;

import java.io.IOException;
import java.net.DatagramPacket;
import java.net.DatagramSocket;
import java.net.InetAddress;
import java.net.SocketException;
import java.util.Date;

import com.mine.logger.storeindb.IStoreLog;

public class UdpListener extends Thread
{
    private int port;

    private IStoreLog storeLog;

    public void setStoreLog(IStoreLog value)
    {
        this.storeLog = value;
        System.out.println("UdpListener > setStoreLog: '" + this.storeLog.toString() + "'");
    }

    public void unsetStoreLog(IStoreLog value)
    {
        if (this.storeLog == value) {
            this.storeLog = null;
        }
        System.out.println("UdpListener > unsetStoreLog");
    }

    public UdpListener()
    {
        // public, no-args constructor needed for Declarative Services !!!
    }

    public UdpListener(int port)
    {
        this.port = port;
    }

    public void run()
    {
        startListener();
    }

    private void startListener()
    {
        try {
            // send command
            DatagramSocket socket = new DatagramSocket(port);

            while (true)
            {
                byte[] b = new byte[1000];
                DatagramPacket recvdPacket = new DatagramPacket(b, b.length);
                socket.receive(recvdPacket);

                System.out.println("UdpListener: Packet received. " + (new String(b)));

                try
                {
                    if (this.storeLog != null)
                        this.storeLog.doStore(new Date(), InetAddress.getByName("0.0.0.0"), port, 1, "UDP", b);
                    else
                        System.err.println("ERROR > UdpListener > run > storeLog is not available.");
                }
                catch (Exception e)
                {
                    System.err.println("ERROR > UdpListener > run > storeLog > Exception: " + e.toString());
                }
            }
        } catch (SocketException e) {
            System.out.println("ERROR > UdpListener > run > SocketException: " + e.getMessage());
        } catch (IOException e) {
            System.out.println("ERROR > UdpListener > run > IOException: " + e.getMessage());
        } catch (Exception e) {
            System.out.println("ERROR > UdpListener > run > Exception: " + e.getMessage());
        }
    }
}

Your code is not thread safe. The storeLog field is read and written by multiple threads without any synchronization. If you have a mutable field that is read and written by more than one thread, you must ensure the field is always safely accessed for both
read and write. I highly
recommend the excellent book Java Concurrency in Practice http://www.javaconcurrencyinpractice.com/
for anyone writing Java code.

Hello, buddy!稿源:Hello, buddy! (源链) | 关于 | 阅读提示

本站遵循[CC BY-NC-SA 4.0]。如您有版权、意见投诉等问题,请通过eMail联系我们处理。
酷辣虫 » 综合编程 » Can declarative services be used in a thread?

喜欢 (0)or分享给?

专业 x 专注 x 聚合 x 分享 CC BY-NC-SA 4.0

使用声明 | 英豪名录